Skip to content

[qualys_vmdr] record missing KB entries in knowledge_base.status instead of error.message#20052

Open
moxarth-rathod wants to merge 2 commits into
elastic:mainfrom
moxarth-rathod:qualys-19961
Open

[qualys_vmdr] record missing KB entries in knowledge_base.status instead of error.message#20052
moxarth-rathod wants to merge 2 commits into
elastic:mainfrom
moxarth-rathod:qualys-19961

Conversation

@moxarth-rathod

@moxarth-rathod moxarth-rathod commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Proposed commit message

qualys_vmdr: record missing KB entries in knowledge_base.status instead of error.message

This change updates the asset_host_detection ingest pipeline so that missing Knowledge Base entries for a QID are recorded in qualys_vmdr.asset_host_detection.knowledge_base.status instead of error.message. With this change, a missing KB entry no longer sets event.kind: pipeline_error or the preserve_original_event tag, while still being recorded for troubleshooting purposes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

Related issues

@moxarth-rathod moxarth-rathod self-assigned this Jul 9, 2026
@moxarth-rathod moxarth-rathod requested review from a team as code owners July 9, 2026 05:56
@moxarth-rathod moxarth-rathod added bugfix Pull request that fixes a bug issue Integration:qualys_vmdr Qualys VMDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels Jul 9, 2026
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

✅ Elastic Docs Style Checker (Vale)

No issues found on modified lines!

The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale.

vera-review-bot[bot]
vera-review-bot Bot reviewed Jul 9, 2026
View reviewed changes
Comment thread packages/qualys_vmdr/changelog.yml Outdated
changes:
- description: Record missing KB entries in `knowledge_base.status` instead of `error.message`, so they no longer mark documents as `pipeline_error`.
type: bugfix
link: https://github.com/elastic/integrations/pull/1

@vera-review-bot vera-review-bot Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: 🟡 Medium confidence: high path: packages/qualys_vmdr/changelog.yml:6

Changelog links a different PR number

Details

This changelog entry's link: points at pull/1, but it was added in PR #​20052. It is likely a leftover template placeholder or a copy from another PR.

Recommendation:

Point the changelog link at this PR:

link: https://github.com/elastic/integrations/pull/20052

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Benchmarks report

Package qualys_vmdr 👍(1) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
knowledge_base 3030.3 2493.77 -536.53 (-17.71%) 💔

To see the full report comment with /test benchmark fullreport

@kcreddy

kcreddy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@moxarth-rathod can you address the CI failure due to PR number mismatch?

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 9, 2026
@elastic-vault-github-plugin-prod

elastic-vault-github-plugin-prod Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

✅ All changelog entries have the correct PR link.

@vera-review-bot

vera-review-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

No issues across the latest commits 92dc723.

Review summary

Issues found across earlier commits 2bbeab3 — 1 medium
  • 🟡 Changelog links a different PR number (link) (Unresolved)

A new commit triggers another review — at most once every 15 minutes. I skip the PR while it's approved or has merge conflicts.

🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills

⚠️ Automated review — verify suggestions before applying.

@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Jul 10, 2026

Copy link
Copy Markdown

💚 Build Succeeded

History

cc @moxarth-rathod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@vera-review-bot vera-review-bot[bot] vera-review-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@moxarth-rathod moxarth-rathod

Labels

bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:qualys_vmdr Qualys VMDR Team:SDE-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[qualys_vmdr] "QID not found in the Knowledge Base" wrongly marks documents as pipeline errors

3 participants

@moxarth-rathod @kcreddy @andrewkroh